Replace c_ptrTo array workarounds with c_addrOf
#27866
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
4 tasks
arifthpe
force-pushed
the
remove-cptr-workarounds
branch
from
13d8e8b to
70a986d
Compare
Reverted as it seems these workarounds have been removed from Sort on main in the meantime. This reverts commit f390c61. Signed-off-by: Anna Rift <anna.rift@hpe.com>
arifthpe
force-pushed
the
remove-cptr-workarounds
branch
2 times, most recently
from
bb6d6fd to
1000b2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace instances of
c_pointer_returnwithc_addrOfin module code (besides CTypes itself), and allow passing domains toc_addrOf.There are a few instances in module code where
c_pointer_returnis used directly rather thanc_ptrToto avoid its special behavior on arrays. However, we now havec_addrOfas an alternative that has no such special behavior that should be used instead. This PR updates all instances to usec_addrOfinstead of workarounds.Resolves https://github.com/Cray/chapel-private/issues/6587.
Originally PR'd the same changes in #26175.
[reviewer info placeholder]
Testing: