-
Notifications
You must be signed in to change notification settings - Fork 421
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #20698 from mppf/remove-homebrew-workaround
Remove workaround for Homebrew libc++ issue This PR removes a workaround for issue #19217 (which is the same issue as Homebrew/homebrew-core#96915 and llvm/llvm-project#54438 ). The problem is solved in the current Homebrew LLVM 14 and LLVM 15 formulae now that libc++ is installed into a different directory than the LLVM libraries. (This problem would still be present for the LLVM 12 and 13 formulae). Since the workaround is removed, this PR adjusts printchplenv to raise an error if using Mac OS X with system LLVM 11, 12, or 13. Such LLVMs will not be selected as a quickstart configuration. Also, it updates prereqs.rst to indicate that LLVM 14 or newer is required on Mac OS X. Reviewed by @daviditen - thanks! - [x] testing on Mac OS X 10.15 "Catalina" - [x] testing on Mac OS X 11 "Big Sur" - [x] testing on Mac OS X 12 "Monterey" (x86) - [x] testing on Mac OS X 12 "Monterey" (M1)
- Loading branch information
Showing
2 changed files
with
27 additions
and
48 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters