We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This looks similar to #34
It appears actions.py has several incorrect instances of body as an argument.
actions.py
body
If I edit to read body=body as in here for kill_microservice: https://github.com/chaostoolkit/chaostoolkit-kubernetes/blob/master/chaosk8s/actions.py#L67
body=body
kill_microservice
The deployment will correctly be deleted. Without that edit, I will get the following:
[2019-06-19 17:32:43 ERROR] => failed: TypeError: delete_namespaced_deployment() takes 3 positional arguments but 4 were given
And the function will not run, no deployment is deleted.
This also appears two other places:
https://github.com/chaostoolkit/chaostoolkit-kubernetes/blob/master/chaosk8s/actions.py#L81
https://github.com/chaostoolkit/chaostoolkit-kubernetes/blob/master/chaosk8s/actions.py#L95
The text was updated successfully, but these errors were encountered:
Hi @maroda,
This is indeed likely a bug here. Looking at the API https://github.com/kubernetes-client/python/blob/master/kubernetes/docs/ExtensionsV1beta1Api.md#delete_namespaced_deployment, the third positional argument is not body indeed.
I'll fix it.
Cheers
Sorry, something went wrong.
Pass body argument as named arg
9791265
Closes #42 Signed-off-by: Sylvain Hellegouarch <sh@defuze.org>
Pass body argument as named arg (#43)
a7dd5db
Successfully merging a pull request may close this issue.
This looks similar to #34
It appears
actions.py
has several incorrect instances ofbody
as an argument.If I edit to read
body=body
as in here forkill_microservice
: https://github.com/chaostoolkit/chaostoolkit-kubernetes/blob/master/chaosk8s/actions.py#L67The deployment will correctly be deleted. Without that edit, I will get the following:
And the function will not run, no deployment is deleted.
This also appears two other places:
https://github.com/chaostoolkit/chaostoolkit-kubernetes/blob/master/chaosk8s/actions.py#L81
https://github.com/chaostoolkit/chaostoolkit-kubernetes/blob/master/chaosk8s/actions.py#L95
The text was updated successfully, but these errors were encountered: