add DCO requirement to GSoC interest page #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Georg J.P. Link <linkgeorg@gmail.com>
geekygirldawn
previously requested changes
Mar 20, 2019
Member
geekygirldawn
left a comment
geekygirldawn
left a comment
There was a problem hiding this comment.
The information about the DCO and how to use the signed-off-by process would be better to have in the contributing docs, rather than referencing an issue. This also has the advantage of making it easy for people to have all of the details about how to contribute in one place. I'm guessing this belongs in the governance Contributing.md file.
Collaborator
|
Good idea @geekygirldawn |
Member
Author
|
I opened a separate pull request for @geekygirldawn's change request: #100 Can I please get an approval for this pr? GSoC students need this information. |
Signed-off-by: Georg J.P. Link <linkgeorg@gmail.com>
Member
Author
|
@geekygirldawn's change request is addressed. The page links to the CONTRIBUTING.md now. |
germonprez
dismissed
geekygirldawn’s stale review
Ready to merge -- taken care of
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a notice to the GSoC interest page to inform students that they are required to include a DCO signoff.