Idea for GSoC: Implementing CHAOSS metrics with Perceval #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germonprez
approved these changes
Jan 29, 2019
Collaborator
germonprez
left a comment
germonprez
left a comment
There was a problem hiding this comment.
Thanks @jgbarah - looks good to me. @GeorgLink ?
GeorgLink
requested changes
Jan 29, 2019
Member
GeorgLink
left a comment
GeorgLink
left a comment
There was a problem hiding this comment.
Thanks for putting this together. I am excited about implementing GMD metrics. I request two minor changes.
GSoC-Ideas.md
Outdated
|
|
||
| \[Below, template for proposing ideas. Pull request with your idea. \] | ||
|
|
||
| ### Idea #x: |
Member
There was a problem hiding this comment.
Please remove the duplicate idea template (lines 43-60)
Contributor
Author
There was a problem hiding this comment.
I did. Thanks for noticing.
GSoC-Ideas.md
Outdated
| and will explore the peculiarities of the metric and its implementation for that data source. | ||
|
|
||
| * Document the notebooks as much as possible, so that any person trying to implement the metric | ||
| can understand not only how to implement it, but also the details that should have into account. |
Member
There was a problem hiding this comment.
line 25: This sentence I don't understand; it seems incomplete: "but also the details that should have into account."
Contributor
Author
There was a problem hiding this comment.
My bad. Is it more clear now?
GeorgLink
approved these changes
Jan 29, 2019
GeorgLink
requested changes
Jan 29, 2019
Member
GeorgLink
left a comment
GeorgLink
left a comment
There was a problem hiding this comment.
Please add link to micro-tasks
jgbarah
force-pushed
the
jgbarah-patch-2
branch
from
6100253 to
2881064
Compare
Hopefully also addressing reviwer comments, including a link to the microtasks and issue for discussion.
jgbarah
force-pushed
the
jgbarah-patch-2
branch
from
2881064 to
c7817ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for GSoC'2019.