Skip to content

Conversation

@InosRahul
Copy link
Contributor

Creating a new PR because rebasing with master was creating conflicts and I did not know how to solve them so forked the repo again and created PR reflecting changes from add-info branch.

Signed-off-by: InosRahul rahulsoni2225@gmail.com

Signed-off-by: InosRahul <rahulsoni2225@gmail.com>
Copy link
Contributor

@jgbarah jgbarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

But still it is not mergeable (maybe something changed due to some other pr being accepted since you rebased). In addition, please use a single commit, if you can.

Copy link
Member

@GeorgLink GeorgLink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @InosRahul

@GeorgLink GeorgLink merged commit a6e4f5f into chaoss:master Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants