Skip to content

Conversation

@MoralCode
Copy link
Contributor

@MoralCode MoralCode commented Oct 23, 2025

Description
This change:

  1. removes several dependencies that were seemingly never used
  2. relocates a couple of dependencies to either the devdependencies area, or removes them since they are transitive dependencies

This PR is a major step towards resolving #3334 (and in future, updating dependencies)

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

I should probably squash these commits

Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MoralCode : Can we walk through this one. I see that most of them are actually not used if we are not running the ML workers ... but I also want to make sure that we possibly use this cleanup to factor the ML workers into an optional Augur subpackage or something .. ?

@MoralCode
Copy link
Contributor Author

None of them should be used, period. For basically every single one of these, I ctrl-F-ed after the name, and looked to see if we were importing it anywhere throughout the entire codebase.

I did also have the idea of making it an optional sub package too, but I'm not sure how that works

@MoralCode MoralCode added the discussion Seeking active feedback, usually for items under active development label Oct 28, 2025
@MoralCode
Copy link
Contributor Author

some of these are for sure still being used by the ml workers

"scikit-image==0.19.1",
"scikit-learn==1.5.0",
sklearn-crfsuite

h5py is  imported by keras (transitive) so can prob be left out

@MoralCode MoralCode added this to the v0.92.0 Release milestone Oct 30, 2025
@MoralCode MoralCode added tech debt dependencies Pull requests that update a dependency file labels Nov 18, 2025
@MoralCode
Copy link
Contributor Author

needs rebase

@MoralCode MoralCode added the pending changes PRs that have review comments that have been added but havent been addressed in a while label Nov 19, 2025
@MoralCode MoralCode self-assigned this Nov 19, 2025
@sgoggins
Copy link
Member

sgoggins commented Dec 9, 2025

Rerunning failed end to end test.

sgoggins
sgoggins previously approved these changes Dec 17, 2025
Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file discussion Seeking active feedback, usually for items under active development pending changes PRs that have review comments that have been added but havent been addressed in a while tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants