-
Notifications
You must be signed in to change notification settings - Fork 948
remove unused dependencies #3336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
sgoggins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MoralCode : Can we walk through this one. I see that most of them are actually not used if we are not running the ML workers ... but I also want to make sure that we possibly use this cleanup to factor the ML workers into an optional Augur subpackage or something .. ?
|
None of them should be used, period. For basically every single one of these, I ctrl-F-ed after the name, and looked to see if we were importing it anywhere throughout the entire codebase. I did also have the idea of making it an optional sub package too, but I'm not sure how that works |
|
some of these are for sure still being used by the ml workers "scikit-image==0.19.1", |
|
needs rebase |
64d05b7 to
b613bb7
Compare
|
Rerunning failed end to end test. |
sgoggins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
b613bb7 to
ab2603f
Compare
Description
This change:
This PR is a major step towards resolving #3334 (and in future, updating dependencies)
Notes for Reviewers
Signed commits
I should probably squash these commits