Format formatting of wait until time #3318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current formatting of time in "sleeping until" message doesn't including leading zeros for single digits minutes (and hours), which is odd:
```python
>>> import time
>>> wait_until_time = time.localtime(1760684520)
>>> f"sleeping until {wait_until_time.tm_hour}:{wait_until_time.tm_min}"
'sleeping until 8:2'
>>> f"sleeping until {wait_until_time.tm_hour:02d}:{wait_until_time.tm_min:02d}"
'sleeping until 08:02'
```
Signed-off-by: Mosè Giordano <765740+giordano@users.noreply.github.com>
sgoggins
added
deployed version
MoralCode
approved these changes
Oct 22, 2025
Contributor
MoralCode
left a comment
MoralCode
left a comment
There was a problem hiding this comment.
lgtm! Seems like the CI is passing and this is trivial enough where id be comfortable merging without having run it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current formatting of time in "sleeping until" message doesn't include leading zeros for single-digit minutes (and hours), which is odd:
Signed commits