facade: refactor facade_phase to return the group itself so that celery can properly convert things into a chord #3273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While I haven't been certain that I can see the facade recollection issue locally, this change allowed me to successfully find
facade_task_success_utilvia a flower task search in my local instance, meaning the tasks that were not running are now running again,The thing that helped me get through this issue was this analysis from GPT5:
Notes for Reviewers
In doing this refactor, I didnt see any other uses of
facade_phasebesides inbuild_facade_repo_collect_request, so it doesnt seem like the specific return type here is being super heavily relied on (although maybe thats due to an unwritten convention as noted in #3272)Signed commits