-
Notifications
You must be signed in to change notification settings - Fork 955
fix(cli): display timezone in output for GitHub key expiry (#3251) #3261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sgoggins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Worth Testing!
sgoggins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like its worth testing, and would make log reading less oblique for non-sys-admins.
Ideally this wouldnt affect the logs, just the table printed by the CLI when checking whether the auth tokens are expired |
|
Kindly review this PR . |
|
Hey , can someone review this and tell me what fixes do I need to make . |
Ulincsys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still several lines of extra space that could be cleaned up, but the code looks good to me
Hey I fixed those extra lines kindly review it |
|
also don't forget to signoff on your commits so the DCO check passes ( |
Signed-off-by: Sajal-Kulshreshtha <sajalkulshreshtha9@gmail.com>
Signed-off-by: Sajal-Kulshreshtha <sajalkulshreshtha9@gmail.com>
Signed-off-by: Sajal-Kulshreshtha <sajalkulshreshtha9@gmail.com>
Signed-off-by: Sajal-Kulshreshtha <sajalkulshreshtha9@gmail.com>
0b6bd72 to
139d5bc
Compare
MoralCode
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR fixes #3251
Updated epoch_to_local_time_with_am_pm in augur/application/cli/github.py to display timezone-aware datetime for GitHub API key reset times.
Output now includes full date, time in 12-hour format with AM/PM, local timezone abbreviation, and UTC offset.
No other logic or functionality was changed.