Skip to content

Conversation

@skools-here
Copy link
Contributor

Description

  • Please include a summary of the change.

This PR fixes #3251

Updated epoch_to_local_time_with_am_pm in augur/application/cli/github.py to display timezone-aware datetime for GitHub API key reset times.

Output now includes full date, time in 12-hour format with AM/PM, local timezone abbreviation, and UTC offset.

No other logic or functionality was changed.

Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Worth Testing!

@sgoggins sgoggins requested a review from Ulincsys September 9, 2025 19:07
sgoggins
sgoggins previously approved these changes Sep 10, 2025
Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like its worth testing, and would make log reading less oblique for non-sys-admins.

@sgoggins sgoggins added workers Related to data workers release Related to releasing a new version of Augur labels Sep 10, 2025
@MoralCode
Copy link
Contributor

would make log reading less oblique for non-sys-admins.

Ideally this wouldnt affect the logs, just the table printed by the CLI when checking whether the auth tokens are expired

@skools-here
Copy link
Contributor Author

Kindly review this PR .

@skools-here
Copy link
Contributor Author

Hey , can someone review this and tell me what fixes do I need to make .

Ulincsys
Ulincsys previously approved these changes Sep 15, 2025
Copy link
Contributor

@Ulincsys Ulincsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still several lines of extra space that could be cleaned up, but the code looks good to me

@skools-here
Copy link
Contributor Author

There are still several lines of extra space that could be cleaned up, but the code looks good to me

Hey I fixed those extra lines kindly review it

@MoralCode
Copy link
Contributor

also don't forget to signoff on your commits so the DCO check passes (git rebase HEAD~N --signoff where N is the number of commits in this pull request)

Signed-off-by: Sajal-Kulshreshtha <sajalkulshreshtha9@gmail.com>
Signed-off-by: Sajal-Kulshreshtha <sajalkulshreshtha9@gmail.com>
Signed-off-by: Sajal-Kulshreshtha <sajalkulshreshtha9@gmail.com>
Signed-off-by: Sajal-Kulshreshtha <sajalkulshreshtha9@gmail.com>
@skools-here skools-here force-pushed the fix-display-timezone-cli branch from 0b6bd72 to 139d5bc Compare September 16, 2025 14:59
Copy link
Contributor

@MoralCode MoralCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MoralCode MoralCode requested a review from Ulincsys September 16, 2025 15:02
@sgoggins sgoggins merged commit fefb48a into chaoss:main Sep 16, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release Related to releasing a new version of Augur workers Related to data workers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display timezone in output of augur CLI for listing github key expiry

4 participants