fix: resolve UniqueViolation error in GitHub releases collection #3245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for GitHub Issue chaoss#3194 where releases collection was failing with psycopg2.errors.UniqueViolation on releases_pkey constraint. Root cause: GitHub API returns release IDs with trailing spaces that don't match existing trimmed database records. Changes: - Add str().strip() to release_id processing in get_release_inf() - Enhance duplicate detection in insert_release() with proper trimming - Add early duplicate detection to prevent unnecessary database operations Signed-off-by: mohsinm-dev <mohsin.mdev@gmail.com>
mohsinm-dev
force-pushed
the
fix-releases-uniqueviolation-3194
branch
from
15e1c32 to
c3b08cb
Compare
sgoggins
approved these changes
Jul 29, 2025
Member
sgoggins
left a comment
sgoggins
left a comment
There was a problem hiding this comment.
Looks like this will identify "false duplicates".
|
|
||
| release_inf = { | ||
| 'release_id': release['id'], | ||
| 'release_id': str(release['id']).strip(), |
Member
There was a problem hiding this comment.
I think this helps to ensure that strings are interpreted as strings, and spaces are removed. So, it should eliminate "false duplicates".
Member
|
@cdolfi : I think this addresses false duplicate types of issues. |
Contributor
|
Seems like this needs to be merged still? any reason it hasnt been? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for GitHub Issue #3194 where releases collection was failing with psycopg2.errors.UniqueViolation on releases_pkey constraint.
Root cause: GitHub API returns release IDs with trailing spaces that don't match existing trimmed database records.
Changes:
Description
This PR fixes #
Notes for Reviewers
Signed commits