deduplicate convert_type_of_value

[MoralCode]

Description
This PR takes two identical functions found in the codebase and refactors them to both import that function from the utils.py file in the application module

Signed commits

• Yes, I signed my commits.

[MoralCode]

i wouldnt exactly call this a bug fix, more just cleanup of potentially old tech debt or something - this doesnt fix anything (augur should operate exactly the same with or without this) - it just helps make the code more maintainable

[Ulincsys]

I think that the preferable location for this function would be in the db/lib.py file. The augur.application.db module is intended to be independent, and so it should not import anything from parent or sibling modules.

We struggled a lot for a long time with circular imports, and the practice of isolating this module was intended to fix that. So, instead, it's better for functionality required by the module to be included in the module, and anything outside of the module that needs it should import it from db/.

[sgoggins]

@MoralCode : Have you seen @Ulincsys 's comment?

[sgoggins]

I think that the preferable location for this function would be in the db/lib.py file. The augur.application.db module is intended to be independent, and so it should not import anything from parent or sibling modules.

We struggled a lot for a long time with circular imports, and the practice of isolating this module was intended to fix that. So, instead, it's better for functionality required by the module to be included in the module, and anything outside of the module that needs it should import it from db/.

This comment ^ @MoralCode

[MoralCode]

Yep, just been distracted and haven't gotten around to moving the function

[MoralCode]

Oops, I don't think I was thinking when I made the code change, so I ended up moving it to db.utils.

It seems like it's a pretty standalone utility function, so it seems like it fits well there

[Ulincsys]

LGTM