Update entrypoint.sh construction of AUGUR_DB from env vars #3226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the test for the DB connection components to not exit with failure if AUGUR_DB can't be constructed. Signed-off-by: John Strunk <jstrunk@redhat.com>
MoralCode
approved these changes
Jul 14, 2025
Contributor
MoralCode
left a comment
MoralCode
left a comment
There was a problem hiding this comment.
I am able to podman run with these changes
$ podman run -it --rm augur-new:latest bash
root@43ce7fefc860:/augur# LGTM
sgoggins
approved these changes
Jul 14, 2025
| echo -e "When AUGUR_DB is not set, you must set AUGUR_DB_HOST, AUGUR_DB_USER,\nAUGUR_DB_PASSWORD, and AUGUR_DB_NAME" | ||
| exit 1 | ||
| # If AUGUR_DB is not set, check for individual environment variables and construct AUGUR_DB connection string | ||
| if [[ -n "$AUGUR_DB_HOST" ]] && [[ -n "$AUGUR_DB_USER" ]] && [[ -n "$AUGUR_DB_PASSWORD" ]] && [[ -n "$AUGUR_DB_NAME" ]]; then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3225