Address warnings from linter #3224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
MoralCode
requested review from
ABrain7710 and
Ulincsys
and removed request for
ABrain7710
Ulincsys
approved these changes
Jul 11, 2025
Contributor
There was a problem hiding this comment.
If possible, I would be greatly interested to figure out how to turn off the "Unnecessary else after X" warnings. IMO they are not helpful, and they encourage a reduction in readability.
Contributor
Author
There was a problem hiding this comment.
If we dont already have one, we can add a pylint config file to the repo to define a set of linting rules to enforce.
https://pylint.pycqa.org/en/latest/user_guide/configuration/all-options.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes linter warnings to make one of the bots be quiet
This PR pretty much just removed unused imports and renames a couple variables to prevent shadowing
Signed commits