Skip to content

Conversation

@ABrain7710
Copy link
Contributor

@ABrain7710 ABrain7710 commented Jul 8, 2025

Description

  • The issue GitLab Data Collection Error for PR Metadata #3185 shows a NoneType exception happenening when trying to retrieve the head_sha, so I fixed this by providing a default value of None if the diff_refs are missing or head_sha or base_sha.
  • Additionally the issue pointed out that the failure handler was assuming that the first paramater to the task would be repo_git, but it this task it can't be the first paramater the celery chain is passing the mr_ids to the first param in the task. To fix this I implemented a method to search the methods parameters for the repo_git parameter.

This PR fixes #
#3185

Signed commits

  • Yes, I signed my commits.

Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgoggins sgoggins requested a review from Ulincsys July 8, 2025 23:24
Copy link
Contributor

@Ulincsys Ulincsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgoggins sgoggins merged commit 9bc4b01 into main Jul 8, 2025
14 checks passed
@sgoggins sgoggins deleted the gitlab-mr-fixes branch July 26, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants