-
Notifications
You must be signed in to change notification settings - Fork 955
add podman copy of the E2E test #3216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
ok so the podman job is failing for expected reasons (i.e. #3195) |
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and I don't really have a way to test this without merging it, so here we go! :D
Update: Ah. I can see the PR has the podman test on it and its running right now. Will wait of course.
|
@MoralCode : Waiting to see what happens in the test, but looking at that issue I wonder if it is simply an issue of those two files not existing in the container yet, and maybe it could be solved with |
|
buildah is using too much disk space: |
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
https://stackoverflow.com/a/75539500 Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
sgoggins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests have passed! LGTM!
Ulincsys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR adds a copy of the end to end CI job that uses podman instead of docker to ensure that any changes are compatible with both
Signed commits