Skip to content

Container cleanup #3211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sgoggins merged 3 commits into from
Jul 7, 2025
Merged

Container cleanup #3211

sgoggins merged 3 commits into from
Jul 7, 2025

Conversation

@MoralCode
Copy link
Contributor

@MoralCode MoralCode commented Jul 2, 2025 •
edited
Loading

Description

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@Ulincsys
Copy link
Contributor

Ulincsys commented Jul 2, 2025

The keyman folder is required for the primary Augur container, because it contains the KeyClient and KeyPublisher classes, which are used by Augur for interacting with the key orchestrator.

See usage examples in augur.application.cli.backend.start() and augur.tasks.github.util.github_data_access.GithubDataAccess.make_request()

@MoralCode MoralCode force-pushed the container-cleanup branch from ddb38ce to c7b43f1 Compare July 2, 2025 18:37
@MoralCode
Copy link
Contributor Author

MoralCode commented Jul 3, 2025

ah yeah i think i learned that the hard way when resolving the other errors I caused here lol

@MoralCode MoralCode force-pushed the container-cleanup branch from c7b43f1 to d320ad7 Compare July 3, 2025 13:22
MoralCode added 3 commits July 3, 2025 09:22
@MoralCode
Adapt copy permissions to work with podman
5c151b6 
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
@MoralCode
no need to mount files into the container that we are going to copy i…
1b78d93 
…n later anyway

Also I worry that this may cause issues if the mounted files dont get correctly detected when they change, leading to builds with stale cache

Signed-off-by: Adrian Edwards <adredwar@redhat.com>
@MoralCode
limit perms so they only change the directories just copied to avoid …
01a938b 
…messing with downloaded python deps

Signed-off-by: Adrian Edwards <adredwar@redhat.com>
@MoralCode MoralCode force-pushed the container-cleanup branch from d320ad7 to 01a938b Compare July 3, 2025 13:22
@MoralCode MoralCode mentioned this pull request Jul 3, 2025
Open
@MoralCode MoralCode marked this pull request as ready for review July 3, 2025 15:34
sgoggins
sgoggins approved these changes Jul 7, 2025
View reviewed changes
Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Lets give it a try.

sgoggins
sgoggins approved these changes Jul 7, 2025
View reviewed changes
Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MoralCode : Note that I tested this on Docker and everything still works. I am assuming you tested on Podman. :)

@sgoggins sgoggins merged commit f3407d1 into chaoss:main Jul 7, 2025
10 of 11 checks passed
@MoralCode MoralCode deleted the container-cleanup branch July 9, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sgoggins sgoggins sgoggins approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to build Augur in podman due to --chmod

3 participants

@MoralCode @Ulincsys @sgoggins