Handle 410 gone when querying github #3208
Conversation
|
Draft because I have a pending question on Slack about how to handle this new exception. as-is this PR will cause a crash at practically the same place in the code, just with a different error message/exception type |
|
If 410 signifies that issue and PR collection cannot continue for that repo, then it seems as though it should be treated the same as a 404. |
|
@MoralCode : Are you still working on this or are you waiting for another PR? |
this is still WIP - i just need to add the logic to handle the new exception type i made and handle it similarly to a 404 per the above suggestion (and make sure that doesnt cause unintended side effects, like augur marking the repo as "doesnt exist") a lot of my ability to test/review/make progress on PRs is currently blocked by getting a local copy of augur running. hoping to have something up and running soon though |
MoralCode
force-pushed
the
disabled-issues-410
branch
from
6f3685d to
893eb9b
Compare
MoralCode
force-pushed
the
disabled-issues-410
branch
from
67215b1 to
1197c64
Compare
…ithub This may happen if requesting issues or issue comments when issues have been disabled for a repo Signed-off-by: Adrian Edwards <adredwar@redhat.com>
…retry Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
MoralCode
force-pushed
the
disabled-issues-410
branch
from
67a41e0 to
99a8223
Compare
|
End to end tests caught a missing colon (after i ran manually because the 3 min timeout cut off the stack trace) |
|
This is ready to go now though |
|
It looks good to me, but I'd like input from @ABrain7710 before merging |
sgoggins
left a comment
sgoggins
left a comment
There was a problem hiding this comment.
Succinct and elegant @MoralCode . Thank you11
3 participants
This may happen if requesting issues or issue comments when issues have been disabled for a repo
Description
This PR fixes #3191
Notes for Reviewers
Signed commits