-
Notifications
You must be signed in to change notification settings - Fork 955
Fix warnings/errors in docs & ensure clean builds #3183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: John Strunk <jstrunk@redhat.com>
Added a new job to check if documentation builds cleanly, using sphinx- build with extra options to ensure all documentation is generated correctly. Signed-off-by: John Strunk <jstrunk@redhat.com>
Signed-off-by: John Strunk <jstrunk@redhat.com>
|
The RTD build is currently broken for https://app.readthedocs.org/api/v2/build/28480746.txt shows the config file that's being used, which is from main, not dev. |
sgoggins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
|
|
||
|
|
||
| **Python 3.9 is not yet supported because TensorFlow, which we use in our machine learning workers, does not yet support Python 3.9.** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK ... wow. This is out of date.. Noting the need to fix it later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this fixed sir??
sgoggins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a jinja version issue based on the detailed debug log out put on readthedocs.io ... going to merge, because I think I fixed it in dev, and this is how we test that ..
|
There are some warnings inside the updated code by you sir @JohnStrunk it requires simple changes if you're doing this let me know otherwise I will do that as I'm new to this org these small changes will help me to understand better. |
Signed-off-by: PredictiveManish <manisht0914@gmail.com>
Signed-off-by: PredictiveManish <manisht0914@gmail.com>
Signed-off-by: PredictiveManish <manisht0914@gmail.com>
Signed-off-by: PredictiveManish <manisht0914@gmail.com>
Signed-off-by: PredictiveManish <manisht0914@gmail.com>
Signed-off-by: PredictiveManish <manisht0914@gmail.com>
Signed-off-by: PredictiveManish <manisht0914@gmail.com>
Description
This PR fixes #3155
Notes for Reviewers
Signed commits