Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: add --port args for jvm preparation #140

Merged
merged 1 commit into from
Jul 25, 2019
Merged

feature: add --port args for jvm preparation #140

merged 1 commit into from
Jul 25, 2019

Conversation

xcaspar
Copy link
Member

@xcaspar xcaspar commented Jul 25, 2019

Describe what this PR does / why we need it

Does this pull request fix one issue?

See #138 for details

Describe how you did it

  1. add --port, -P flag to specify the agent port, the flag is unnecessary.
  2. check response returns when attaching failed and print the solution tips.

Describe how to verify it

blade prepare jvm --process xxx --port 8703

@xcaspar xcaspar added the type/enhancement New feature or request label Jul 25, 2019
@xcaspar xcaspar merged commit 6073ef5 into master Jul 25, 2019
@xcaspar xcaspar deleted the 0.2.0-dev branch July 25, 2019 05:27
@xcaspar xcaspar added this to the 0.2.0 milestone Jul 25, 2019
@chaosblade-bot chaosblade-bot mentioned this pull request Jul 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type/enhancement New feature or request
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
1 participant
@xcaspar