Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add caught interrupt supprot for graceful exiting #27

Merged
merged 2 commits into from
Apr 15, 2020
Merged

add caught interrupt supprot for graceful exiting #27

merged 2 commits into from
Apr 15, 2020

Conversation

mingcheng
Copy link
Contributor

Describe what this PR does / why we need it

add caught interrupt supprot for graceful exiting

Does this pull request fix one issue?

The kill -9 <pid> command is kill process by OS that will be caught resources (eg memory, disk read handler..) not recycle not immediately. So kill -HUP is good choice to exiting or stop process more graceful. see more https://en.wikipedia.org/wiki/Kill_(command).

btw: I consider directory forlinux maybe duplicate?

@xcaspar xcaspar self-requested a review April 15, 2020 11:34
@xcaspar xcaspar added this to the v0.6.0 milestone Apr 15, 2020
@xcaspar xcaspar added the type/enhancement New feature or request label Apr 15, 2020
@xcaspar
Copy link
Member

xcaspar commented Apr 15, 2020

@mingcheng Thank you for your contribution.

@xcaspar xcaspar merged commit 7d3f7b8 into chaosblade-io:master Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants