chore: replace fastjson to jackson #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xcaspar <x.caspar@gmail.com>
tiny-x
reviewed
Sep 21, 2020
| @@ -188,7 +191,8 @@ private Request getRequestFromParams(HttpServletRequest httpServletRequest) { | |||
|
|
|||
| private Request getRequestFromBody(HttpServletRequest httpServletRequest) throws IOException { | |||
| ServletInputStream inputStream = httpServletRequest.getInputStream(); | |||
| Map<String, String> parameters = JSON.parseObject(inputStream, Map.class); | |||
| MapType mapType = TypeFactory.defaultInstance().constructMapType(HashMap.class, String.class, String.class); | |||
| Map<String, String> parameters = new ObjectMapper().readValue(inputStream, mapType); | |||
There was a problem hiding this comment.
should be use ObjectMapper singleton and lightweight ObjectReader ObjectWrite
Signed-off-by: xcaspar <x.caspar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xcaspar x.caspar@gmail.com
Describe what this PR does / why we need it
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews