This repository has been archived by the owner on Sep 12, 2024. It is now read-only.
fix(alerts): ensure percent change is not flipped for neg. exp. vals #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When expected value was negative, the percent change would be in the opposite direction of what it should be. Fixed by using absolute value of expected value in the denominator. Tested on these cases: - Both positive: actual higher than expected - Both positive: actual lower than expected - Actual positive and expected negative - Actual negative and expected positive - Both negative: actual higher than expected - Both negative: actual lower than expected
Samyak2
added
🐛 bug
|
|
✅ Deploy Preview for frontend-sb ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When expected value was negative, the percent change would be in the opposite direction of what it should be.
Fixed by using absolute value of expected value in the denominator.
Tested on these cases: