feat(DataTable): implement TanStack Table #2055
Merged
+874
−498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use tanstack as basis for table implementation - add in relevant stories for styles
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## aholloway/EDS-1209 #2055 +/- ##
======================================================
- Coverage 97.46% 97.34% -0.13%
======================================================
Files 111 111
Lines 2648 2670 +22
Branches 680 694 +14
======================================================
+ Hits 2581 2599 +18
- Misses 65 68 +3
- Partials 2 3 +1 ☔ View full report in Codecov by Sentry. |
ahuth
reviewed
Sep 6, 2024
| }, | ||
| render: (args) => { | ||
| // eslint-disable-next-line react-hooks/rules-of-hooks | ||
| const [data] = React.useState(() => [...defaultData]); |
There was a problem hiding this comment.
If it's not being changed, why does the data need to be in state?
There was a problem hiding this comment.
This is just some boilerplate to be used later. We want to support selectable rows and sorting, which state will help with. I'm also going to factor these render calls so that they aren't so copy-paste
booc0mtaco
added a commit
that referenced
this pull request
Sep 6, 2024
- use tanstack as basis for table implementation - add in relevant stories for styles
booc0mtaco
added a commit
that referenced
this pull request
Sep 9, 2024
- use tanstack as basis for table implementation - add in relevant stories for styles - add in snapshots for tests
booc0mtaco
added a commit
that referenced
this pull request
Sep 11, 2024
- use tanstack as basis for table implementation - add in relevant stories for styles - add in snapshots for tests
booc0mtaco
added a commit
that referenced
this pull request
Sep 12, 2024
- use tanstack as basis for table implementation - add in relevant stories for styles - add in snapshots for tests
booc0mtaco
added a commit
that referenced
this pull request
Sep 12, 2024
- use tanstack as basis for table implementation - add in relevant stories for styles - add in snapshots for tests
booc0mtaco
added a commit
that referenced
this pull request
Sep 16, 2024
- use tanstack as basis for table implementation - add in relevant stories for styles - add in snapshots for tests
booc0mtaco
added a commit
that referenced
this pull request
Sep 17, 2024
- use tanstack as basis for table implementation - add in relevant stories for styles - add in snapshots for tests
booc0mtaco
added a commit
that referenced
this pull request
Sep 26, 2024
* feat(DataTable): introduce 1.0 component - new component for complex data-based table content - add in the documentation for props - add in types, layouts, and test - add in snapshots - make use of newly-added tokens * feat(DataTable): implement TanStack Table (#2055) - use tanstack as basis for table implementation - add in relevant stories for styles - add in snapshots for tests * feat(DataTable): support selection and additional column styling - add stories to show column separators - add stories for sticky column/row treatments * feat(DataTable): add groupBy support - add implementation detail stories - update snapshots and tests * feat(DataTable): handle conditional shadow on pinned header * docs(DataTable): update comment format
Merged
booc0mtaco
added a commit
that referenced
this pull request
Sep 27, 2024
## [15.4.0](v15.3.1...v15.4.0) (2024-09-26) [Storybook](https://61313967cde49b003ae2a860-sdpxmjxjai.chromatic.com/) ### Features * **Button:** support for not-allowed cursor when disabled ([#2052](#2052)) ([46cb9f6](46cb9f6)) * **DataTable:** introduce 1.0 component ([#2050](#2050)) ([ffd0e82](ffd0e82)), closes [#2055](#2055) ### Bug Fixes * **Button:** apply external styles when disabled ([#2060](#2060)) ([e762d8b](e762d8b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this merges into the existing branch for EDS-1209. posting to generate the snapshots and such, but will just merge into that in-progress work
Test Plan: