Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Card): add spacing between eyebrow and title #2040

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

booc0mtaco
Copy link
Contributor

@booc0mtaco booc0mtaco commented Aug 22, 2024

Update the spacing between eyebrow and title to match design

Test Plan:

  • Wrote/updated automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, and here are the details:

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.43%. Comparing base (aed0f09) to head (b502583).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2040   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files         109      109           
  Lines        2613     2613           
  Branches      664      664           
=======================================
  Hits         2546     2546           
  Misses         65       65           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@booc0mtaco
Copy link
Contributor Author

Screenshot 2024-08-22 at 17 47 24

Copy link

size-limit report 📦

Path Size
components 89.2 KB (0%)
styles 27.25 KB (+0.02% 🔺)

@booc0mtaco booc0mtaco merged commit d6ee15d into next Aug 23, 2024
15 checks passed
@booc0mtaco booc0mtaco deleted the aholloway/EDS-1400 branch August 23, 2024 14:48
@booc0mtaco booc0mtaco mentioned this pull request Aug 23, 2024
booc0mtaco added a commit that referenced this pull request Aug 23, 2024
## [15.3.0](v15.2.1...v15.3.0) (2024-08-23)

[Storybook](https://61313967cde49b003ae2a860-vuzmfnjuoj.chromatic.com/)

Figma Components Library:
🟢  No breaking changes
- EDS-toastNotification:
  - deleted the dissmissType property
  - Added Toast Pattern documentation to handle multiple toasts
- EDS-popover: added EDS-popover 2.0 component

### Features

* **config:** add transition durations for tailwind ([#2036](#2036)) ([aed0f09](aed0f09))
* **Popover:** update theming to 2.0 ([#2031](#2031)) ([c5ab351](c5ab351))
* **tokens:** add in additional table tokens ([#2035](#2035)) ([a698a5b](a698a5b))
* **tokens:** update visited tokens ([#2034](#2034)) ([df84c87](df84c87))


### Bug Fixes

* **Card:** add spacing between eyebrow and title ([#2040](#2040)) ([d6ee15d](d6ee15d))
* **Link:** handle inverse variant for standalone links ([#2042](#2042)) ([351d7fd](351d7fd))
* **Popover:** update component version number ([#2038](#2038)) ([9940d76](9940d76))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants