fix: P in P #1999
Merged
fix: P in P #1999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahuth
commented
Jun 24, 2024
| @@ -1 +1 @@ | |||
| 20.9.0 | |||
| 20.11.1 | |||
There was a problem hiding this comment.
While here, may as well use the same version of Node as we do in Bento.
size-limit report 📦
|
Our apps render markdown for notifications which contain p tags. This results in p tags nested within p tags, which is not valid HTML and causes React runtime validations to complain.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1999 +/- ##
=======================================
Coverage 97.40% 97.40%
=======================================
Files 109 109
Lines 2581 2581
Branches 648 648
=======================================
Hits 2514 2514
Misses 65 65
Partials 2 2 ☔ View full report in Codecov by Sentry. |
booc0mtaco
approved these changes
Jun 24, 2024
Merged
booc0mtaco
added a commit
that referenced
this pull request
Jul 3, 2024
### [15.0.1](v15.0.0...v15.0.1) (2024-07-02) [Storybook](https://61313967cde49b003ae2a860-cvcvanlzyx.chromatic.com/) ### Bug Fixes * P in P ([#1999](#1999)) ([7566e2c](7566e2c)) * **Table:** allow nodes in header cells ([#2001](#2001)) ([e471fad](e471fad))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a
<span>instead of<p>for Notification subtitlesOur apps render markdown for notifications which contain p tags. This results in p tags nested within p tags, which is not valid HTML and causes React runtime validations to complain.