feat(Select): add support for label prop #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
size-limit report 📦
|
|
This will also greatly improve the documentation table, and code snippets in the resulting storybook pages.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #1837 +/- ##
==========================================
+ Coverage 92.46% 92.47% +0.01%
==========================================
Files 147 147
Lines 2761 2765 +4
Branches 740 745 +5
==========================================
+ Hits 2553 2557 +4
Misses 192 192
Partials 16 16 ☔ View full report in Codecov by Sentry. |
jeremiah-clothier
approved these changes
Jan 26, 2024
booc0mtaco
force-pushed
the
aholloway/EFI-1540
branch
from
a3be637
to
3f038c6
Compare
- provide a cleaner API for implementing the label similar to other form fields - add disabled prop should a user want to still detach and use Select.Label - update styles to support this - docs: clean up all Select stories and API table in storybook - docs: greatly simplify the presentation of Select documentation - update relevant snapshots
booc0mtaco
force-pushed
the
aholloway/EFI-1540
branch
from
3f038c6
to
4c14dcc
Compare
Merged
booc0mtaco
added a commit
that referenced
this pull request
Feb 1, 2024
## [13.10.0](v13.9.0...v13.10.0) (2024-02-01) [Storybook](https://61313967cde49b003ae2a860-xjckjitaia.chromatic.com/) ### Features * **Select:** add ability to handle click and change event handlers ([#1839](#1839)) ([54a3de8](54a3de8)) * **Select:** add support for label prop ([#1837](#1837)) ([c032ff2](c032ff2))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Test Plan: