feat(checkbox)!: remove top level subcomponents #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/EFI-1219 #1693 +/- ##
====================================================
- Coverage 92.93% 92.89% -0.04%
====================================================
Files 180 176 -4
Lines 2843 2830 -13
Branches 716 716
====================================================
- Hits 2642 2629 -13
Misses 184 184
Partials 17 17
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
booc0mtaco
approved these changes
Jul 17, 2023
| .checkbox__label--md { | ||
| /* Center the first line of the medium label with the checkbox. */ | ||
| position: relative; | ||
| top: 0.0625rem; |
There was a problem hiding this comment.
here's that 1/8 thing again. I imagine radio and checkbox need and use it for the same exact reason
booc0mtaco
pushed a commit
that referenced
this pull request
Jul 19, 2023
Merged
booc0mtaco
added a commit
that referenced
this pull request
Aug 15, 2023
## [13.0.0](v12.4.2...v13.0.0) (2023-08-14) ### ⚠ BREAKING CHANGES * **link:** remove text-link tokens for link t3 tokens (#1639) * **colors:** remove old colors and convert to input and show figma token (#1711) * remove deprecated dropdown (#1657) * **banner:** remove component (#1702) * remove legacy tokens and typography mixins (#1709) * **Grid:** remove top-level sub-component(s) (#1703) * **dragdrop:** remove top level subcomponents (#1697) * **Fieldset:** remove top-level sub-component(s) (#1695) * **HorizontalStepper:** remove top-level sub-component(s) (#1696) * **Card:** remove top-level sub-component(s) (#1692) * **checkbox:** remove top level subcomponents (#1693) * **radio:** remove top level subcomponents (#1690) * **DataBar:** remove top-level sub-component(s) (#1686) * **Modal:** remove top-level sub-component(s) (#1689) * **searchbar:** remove top level subcomponents (#1687) * **table:** remove top-level sub-components (#1685) * **toolbar:** remove component (#1683) * **Breadcrumbs:** remove top-level sub-component (#1680) * **timelinenav:** remove top-level sub-component (#1681) ### Features * **Breadcrumbs:** remove top-level sub-component ([#1680](#1680)) ([669081d](669081d)) * **Card:** remove top-level sub-component(s) ([#1692](#1692)) ([7ec01f4](7ec01f4)) * **checkbox:** remove top level subcomponents ([#1693](#1693)) ([87b12e8](87b12e8)) * **DataBar:** remove top-level sub-component(s) ([#1686](#1686)) ([b4b9276](b4b9276)) * **dragdrop:** remove top level subcomponents ([#1697](#1697)) ([b4fd00c](b4fd00c)) * **Fieldset:** remove top-level sub-component(s) ([#1695](#1695)) ([0c8280d](0c8280d)) * **Grid:** remove top-level sub-component(s) ([#1703](#1703)) ([c8925c9](c8925c9)) * **HorizontalStepper:** remove top-level sub-component(s) ([#1696](#1696)) ([188fd99](188fd99)) * **Layout:** mark layout components as deprecated ([#1700](#1700)) ([930a369](930a369)) * **Modal:** remove top-level sub-component(s) ([#1689](#1689)) ([8743e62](8743e62)) * **radio:** remove top level subcomponents ([#1690](#1690)) ([82da617](82da617)) * remove legacy tokens and typography mixins ([#1709](#1709)) ([ec3e819](ec3e819)) * **searchbar:** remove top level subcomponents ([#1687](#1687)) ([d13bb6c](d13bb6c)) * **table:** remove top-level sub-components ([#1685](#1685)) ([742a530](742a530)) * **timelinenav:** remove top-level sub-component ([#1681](#1681)) ([f46eca7](f46eca7)) ### Bug Fixes * **Avatar:** support display names using emoji and multi-byte ([#1716](#1716)) ([1294022](1294022)) * update token exports ([#1722](#1722)) ([982c55f](982c55f)) * **banner:** remove component ([#1702](#1702)) ([356550c](356550c)) * **colors:** remove old colors and convert to input and show figma token ([#1711](#1711)) ([c9a5079](c9a5079)) * **link:** remove text-link tokens for link t3 tokens ([#1639](#1639)) ([d35cfe4](d35cfe4)) * remove deprecated dropdown ([#1657](#1657)) ([26d1694](26d1694)) * **toolbar:** remove component ([#1683](#1683)) ([bd47899](bd47899))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EFI-1223
Summary:
Test Plan: