Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Avatar): add responsive image handling to component #1679

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

booc0mtaco
Copy link
Contributor

Summary:

  • EDS storybook and component structure implements a global responsive style for width: 100% which doesn't get sent along with the component
  • Add this to the component using semantic class name

Test Plan:

  • Wrote automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, but I want to keep the details secret
  • Manually tested my changes, and here are the details:
    • update the snapshots

@booc0mtaco booc0mtaco requested a review from a team July 10, 2023 21:47
@github-actions
Copy link

github-actions bot commented Jul 10, 2023

size-limit report 📦

Path Size
components 111.98 KB (+0.01% 🔺)
styles 38 KB (+0.04% 🔺)

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #1679 (a90586b) into next (d4145d9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             next    #1679   +/-   ##
=======================================
  Coverage   93.23%   93.23%           
=======================================
  Files         222      222           
  Lines        2970     2971    +1     
  Branches      721      722    +1     
=======================================
+ Hits         2769     2770    +1     
  Misses        184      184           
  Partials       17       17           
Impacted Files Coverage Δ
src/components/Avatar/Avatar.tsx 87.50% <100.00%> (+0.54%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@booc0mtaco booc0mtaco changed the title Aholloway/efi 1118 fix(Avatar): add responsive image handling to component Jul 10, 2023
Copy link
Contributor

@jinlee93 jinlee93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@booc0mtaco booc0mtaco merged commit 7ff27ff into next Jul 12, 2023
@booc0mtaco booc0mtaco deleted the aholloway/EFI-1118 branch July 12, 2023 19:40
@booc0mtaco booc0mtaco mentioned this pull request Jul 20, 2023
booc0mtaco added a commit that referenced this pull request Jul 20, 2023
### [12.4.2](v12.4.1...v12.4.2) (2023-07-20)

### Bug Fixes

* **Avatar:** add responsive image handling to component ([#1679](#1679)) ([7ff27ff](7ff27ff))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants