feat: add tier-3 tokens to DataBar and ProgressBar #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- define tokens for background and border for these two components - these point to tier 1 values currently - use new tokens in specified components
size-limit report 📦
|
booc0mtaco
commented
May 23, 2023
| @@ -19,18 +19,11 @@ export default { | |||
| }, | |||
| parameters: { | |||
| badges: ['1.0'], | |||
| backgrounds: { | |||
There was a problem hiding this comment.
The background parameter lets you change the default background color on individual stories. This is better than doing the same using a special decorator with inline styles.
Added to both databar and progress bar to align snapshots
There was a problem hiding this comment.
the values we can use are defined here: https://github.com/chanzuckerberg/edu-design-system/blob/main/.storybook/preview.tsx#L48-L63
|
|
jinlee93
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Test Plan: