Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Slider): add alignment styles and recipes #1567

Merged
merged 1 commit into from
Mar 29, 2023
Merged

feat(Slider): add alignment styles and recipes #1567

merged 1 commit into from
Mar 29, 2023

Conversation

booc0mtaco
Copy link
Contributor

Summary:

  • small tweaks to the sytling of marker text
  • several recipes to support examples in ZeroHeight
  • integrate examples with some interactivity and animation

Test Plan:

  • Wrote automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, but I want to keep the details secret
  • Manually tested my changes, and here are the details:
    • add new snapshots for tests

@booc0mtaco
Copy link
Contributor Author

Screenshot 2023-03-28 at 18 54 59

Screenshot 2023-03-28 at 18 55 13

Screenshot 2023-03-28 at 18 55 30

Screenshot 2023-03-28 at 18 54 42

Demo using transitions:

Screen.Recording.2023-03-28.at.18.54.21.mov

@github-actions
Copy link

github-actions bot commented Mar 29, 2023 •
edited
Loading

size-limit report 📦

Path Size
components 118.34 KB (0%)
styles 3.1 KB (0%)

@codecov
Copy link

codecov bot commented Mar 29, 2023 •
edited
Loading

Codecov Report

Merging #1567 (3903f26) into next (d4ddfd5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #1567   +/-   ##
=======================================
  Coverage   91.88%   91.88%           
=======================================
  Files         279      279           
  Lines        4249     4249           
  Branches      772      772           
=======================================
  Hits         3904     3904           
  Misses        320      320           
  Partials       25       25
Impacted Files Coverage Δ
src/components/Slider/Slider.stories.tsx 89.65% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@booc0mtaco booc0mtaco requested a review from a team March 29, 2023 00:16
jinlee93
jinlee93 approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@jinlee93 jinlee93 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good pending a couple q's

@booc0mtaco
feat(Slider): add alignment styles and recipes
3903f26 
- small tweaks to the sytling of marker text
- several recipes to support examples in ZeroHeight
- integrate examples with some interactivity and animation
@booc0mtaco booc0mtaco merged commit 900d102 into next Mar 29, 2023
@booc0mtaco booc0mtaco deleted the aholloway/EDS-869 branch March 29, 2023 21:22
@booc0mtaco booc0mtaco mentioned this pull request Mar 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinlee93 jinlee93 jinlee93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@booc0mtaco @jinlee93