fix(Menu): reset menu item hover and defer to popover (#1653)

- reset any color set directly on the menu item line - set the state color to our text/neutral-default color
chanzuckerberg · Jun 6, 2023 · f329e4d · f329e4d
1 parent 94a11d0
commit f329e4d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/components/Menu/Menu.module.css b/src/components/Menu/Menu.module.css
@@ -53,3 +53,8 @@
   text-decoration: none;
   color: inherit;
 }
+
+/* Unset the hover on the menu item, as this is handled by the PopoverListItem */
+.menu__item:hover {
+  color: unset;
+}
diff --git a/src/components/PopoverListItem/PopoverListItem.module.css b/src/components/PopoverListItem/PopoverListItem.module.css
@@ -14,6 +14,7 @@
 }
 
 .popover-list-item--active {
+  color: var(--eds-theme-color-text-neutral-default);
   background-color: var(--eds-theme-color-background-neutral-default-hover);
 }