Skip to content

Commit

Permalink
fix: upgrade axe-core from 4.4.3 to 4.6.3
Browse files Browse the repository at this point in the history
  • Loading branch information
ahuth committed Feb 25, 2023
1 parent 9d3e22e commit af3f9c5
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 12 deletions.
2 changes: 0 additions & 2 deletions .github/renovate.json5
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@
},

ignoreDeps: [
// axe-core starting v4.5 causes some axe-storybook tests to time out, ticket: EDS-779
'axe-core',
// headlessui starting v1.7.6 causes some downstream feature tests to fail
'@headlessui/react',
],
Expand Down
7 changes: 7 additions & 0 deletions .storybook/pages/AlongDemo/AlongDemo.stories.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,11 @@ export const WatchPage: StoryObj<Args> = {
const nextPageButton = await canvas.findByText('Hogwarts');
userEvent.click(nextPageButton);
},
parameters: {
axe: {
// Don't run axe on this story. The video seems to cause asset preloading to fail (even when
// the video has preload="none").
skip: true,
},
},
};
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@
"@types/react-beautiful-dnd": "^13.1.3",
"@types/react-dom": "^18.0.11",
"@types/react-portal": "^4.0.4",
"axe-core": "4.4.3",
"axe-core": "4.6.3",
"chromatic": "^6.17.0",
"codecov": "^3.8.3",
"copyfiles": "^2.4.1",
Expand Down
11 changes: 2 additions & 9 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1674,7 +1674,7 @@ __metadata:
"@types/react-beautiful-dnd": ^13.1.3
"@types/react-dom": ^18.0.11
"@types/react-portal": ^4.0.4
axe-core: 4.4.3
axe-core: 4.6.3
chromatic: ^6.17.0
clsx: ^1.2.1
codecov: ^3.8.3
Expand Down Expand Up @@ -6357,14 +6357,7 @@ __metadata:
languageName: node
linkType: hard

"axe-core@npm:4.4.3":
version: 4.4.3
resolution: "axe-core@npm:4.4.3"
checksum: c3ea000d9ace3ba0bc747c8feafc24b0de62a0f7d93021d0f77b19c73fca15341843510f6170da563d51535d6cfb7a46c5fc0ea36170549dbb44b170208450a2
languageName: node
linkType: hard

"axe-core@npm:^4.2.0, axe-core@npm:^4.6.2":
"axe-core@npm:4.6.3, axe-core@npm:^4.2.0, axe-core@npm:^4.6.2":
version: 4.6.3
resolution: "axe-core@npm:4.6.3"
checksum: d0c46be92b9707c48b88a53cd5f471b155a2bfc8bf6beffb514ecd14e30b4863e340b5fc4f496d82a3c562048088c1f3ff5b93b9b3b026cb9c3bfacfd535da10
Expand Down

0 comments on commit af3f9c5

Please sign in to comment.