[Improvement] 누락된 규칙 추가 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonoogi
requested review from
solchan87,
elesahich,
heoblitz,
kbw2204,
ghis22130,
zoyi-jin,
jam0128 and
exponentChoi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
실제로 컨벤션으로 적용되어 함께 리뷰에 적용하고 있으나 가이드 문서에는 누락되어있는 규칙을 추가합니다.
추가한 규칙은 다음과 같습니다.
equalToSuperview사용Constraint변수 따로 빼지 않고 그냥 해당 뷰에updateConstraints호출하기super함수 호출시 아래에 빈 줄 추가Subview추가시addSubviews,addArrangedSubviews함수 사용isNil,isNotNil...)이거 외에도 더 있긴 할 것 같은데 지금 가장 명확하게 쓰이는 거는 이정도인것 같습니다. 혹시 제가 놓친게 있으면 말씀주세요!