-
Notifications
You must be signed in to change notification settings - Fork 51
Icon update PR made by bezier-asset main #2682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Walkthrough@channel.io/bezier-icons ํจํค์ง์ ๋ํ ๋ณ๊ฒฝ์ ํ์ผ์ด ์ถ๊ฐ๋์ด ๋ง์ด๋ ๋ฆด๋ฆฌ์ค๋ฅผ ๊ธฐ๋กํฉ๋๋ค. chat-edit.svg ์ถ๊ฐ์ square.svg ์์ ์ด โUpdate iconsโ ์น์ ์ ๋ช ์๋์์ต๋๋ค. ์ฝ๋ ๋๋ ๋ฐํ์ ๋์ ๋ณ๊ฒฝ์ ์์ต๋๋ค. Changes
Sequence Diagram(s)Estimated code review effort๐ฏ 1 (์ฌ์ํจ) | โฑ๏ธ ~2๋ถ Possibly related PRs
Suggested reviewers
Poem
Tip ๐ Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. โจ Finishing Touches๐งช Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ๐ชง TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov Reportโ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2682 +/- ##
=======================================
Coverage 79.21% 79.21%
=======================================
Files 145 145
Lines 2877 2877
Branches 923 923
=======================================
Hits 2279 2279
- Misses 563 594 +31
+ Partials 35 4 -31 โ View full report in Codecov by Sentry. ๐ New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
๐งน Nitpick comments (1)
.changeset/icon-update-1755766677659.md (1)
5-13
: ์ฒด์ธ์ง๋ก๊ทธ ๋ณธ๋ฌธ์ ์กฐ๊ธ ๋ ๊ตฌ์ฒด์ ์ผ๋ก ๋ค๋ฌ์ด ์ฃผ์ธ์.์๋น์ ๊ด์ ์์ ๋ณํ ์์ง๋ฅผ ํ ์ค์ ์์ฝํ๊ณ , ๋ณ๊ฒฝ ์์ด์ฝ์ ์ฑ๊ฒฉ(์ ๋ ฌ/ํจ์ค ์์ ๋ฑ)์ ์งง๊ฒ ๋จ๊ธฐ๋ฉด ์ถ์ ์ฑ์ด ์ข์์ง๋๋ค.
๋ค์๊ณผ ๊ฐ์ด ๊ฐ๊ฒฐํ ์์ฝ ํ์ ์ ์๋๋ฆฝ๋๋ค:
-Update icons - -Added - -- chat-edit.svg - -Modified - -- square.svg +Update icons: add chat-edit; update square + +- Added: chat-edit.svg +- Changed: square.svg + - (์: ํจ์ค ์ ์ /์ ๋ ฌ ๋ณด์ /์๊ฐ ๊ท ์ผํ ๋ฑ ๊ตฌ์ฒดํ)
๐ Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
๐ก Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
โ Files ignored due to path filters (2)
packages/bezier-icons/icons/chat-edit.svg
is excluded by!**/*.svg
packages/bezier-icons/icons/square.svg
is excluded by!**/*.svg
๐ Files selected for processing (1)
.changeset/icon-update-1755766677659.md
(1 hunks)
โฐ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: CodeQL-Build
- GitHub Check: CI
- GitHub Check: Chromatic
๐ Additional comments (2)
.changeset/icon-update-1755766677659.md (2)
1-13
: ๋ณ๊ฒฝ์ ํ์ผ ์ถ๊ฐ ์์ฒด๋ ๋ฆด๋ฆฌ์ค ํ์ดํ๋ผ์ธ ๊ด์ ์์ ์ ์ ํฉ๋๋ค.์์ด์ฝ ์ถ๊ฐ/์์ PR์ changeset์ ํฌํจํด ๋ฆด๋ฆฌ์ฆ๋ฅผ ํธ๋ฆฌ๊ฑฐํ๋ ํ๋ฆ์ด ์ ์ง์ผ์ก์ต๋๋ค.
1-3
: ํ๋ฐํธ๋งคํฐ ํ์ ๋ฐ ๋ฆด๋ฆฌ์ค ํ์ ๊ฒ์ฆ ์์ฒญ
ํ๋ฐํธ๋งคํฐ ํ์์ ์ ์ ํด ๋ณด์ ๋๋ค. ์ ์์ด์ฝ ์ถ๊ฐ๋ minor ๋ฆด๋ฆฌ์ค๊ฐ ํ๋นํ์ง๋ง, ๊ธฐ์กดsquare.svg
๋ณ๊ฒฝ ๋ฒ์์ ๋ฐ๋ผ์๋ patch ๋๋ ์ ์ฌ์ breaking์ด ๋ ์ ์์ผ๋ฏ๋ก, SemVer ์ ์ฑ ๊ณผ ์์ด์ฝ ๊ฐ์ด๋์ ๋ง๊ฒ ์ฌํ์ธํด ์ฃผ์ธ์.
square.svg
๋ณ๊ฒฝ ๋น๊ต
์์ ์คํฌ๋ฆฝํธ์์ ์ ๋ ๊ฒฝ๋ก ์ฌ์ฉ์ผ๋ก ์ธํด main ๋ธ๋์น์ ๋น๊ต๊ฐ ์คํจํ์ต๋๋ค. ๋ฆฌํฌ์งํ ๋ฆฌ ๋ฃจํธ ๊ธฐ์ค์ ์๋ ๊ฒฝ๋ก๋ฅผ ์ฌ์ฉํด ์๋ ์์์ฒ๋ผ ๋ค์ ํ์ธํด ์ฃผ์ธ์:# 1) main ๋๊ธฐํ git fetch origin main --depth=1 # 2) repo-relative ๊ฒฝ๋ก ์ง์ square_rel_path="packages/bezier-icons/icons/square.svg" # 3) main ๋ฒ์ ๊ฐ์ ธ์ค๊ธฐ git show origin/main:$square_rel_path > /tmp/square_main.svg # 4) ์ฃผ์ ์์ฑ ๋น๊ต diff -u <(rg -n 'viewBox="[^"]+"' "$square_rel_path") <(rg -n 'viewBox="[^"]+"' /tmp/square_main.svg) || true diff -u <(rg -n 'width=|height=' "$square_rel_path") <(rg -n 'width=|height=' /tmp/square_main.svg) || true diff -u <(rg -n 'stroke=|stroke-width=|fill=' "$square_rel_path") <(rg -n 'stroke=|stroke-width=|fill=' /tmp/square_main.svg) || true์ ๊ฒฐ๊ณผ๋ฅผ ํตํด viewBox, ํฌ๊ธฐ, ์คํธ๋กํฌ/Fill ์์ฑ์ ๋ณ๊ฒฝ ์ฌ๋ถ๋ฅผ ํ์ธํ๊ณ , ๋ณ๊ฒฝ์ด ์๊ฐ์ ๋ธ๋ ์ดํน์ ์ผ์ผํค์ง ์๋์ง ๊ฒ์ฆํด ์ฃผ์ธ์.
chat-edit.svg
๋ฑ๋ก ํ์ธ
์๋ก ์ถ๊ฐ๋chat-edit.svg
๊ฐ ์์ด์ฝ ๋ ์ง์คํธ๋ฆฌ๋ ์ธ๋ฑ์ค ํ์ผ์ ์ ์์ ์ผ๋ก ๋ฐ์๋๋์ง ์ฝ๋๋ฒ ์ด์ค ์ ๋ฐ(์:packages/bezier-icons/index.ts
๋ฑ)์์ ๊ฒ์ํด ์ฃผ์ธ์.rg -nP 'chat[-_]?edit' -g '!**/dist/**'์ ๊ฒ์ฆ ๊ฒฐ๊ณผ๋ฅผ ๋ฐํ์ผ๋ก minor ๋ฆด๋ฆฌ์ค๊ฐ ์ ์ ํ์ง ๋ค์ ํ ๋ฒ ํ์ธ ๋ถํ๋๋ฆฝ๋๋ค.
Chromatic Report๐ Congratulations! Your build was successful! |
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @channel.io/bezier-icons@0.47.0 ### Minor Changes - Update icons ([#2682](#2682)) by @ch-builder Added - chat-edit.svg Modified - square.svg ## bezier-figma-plugin@0.7.5 ### Patch Changes - Updated dependencies - @channel.io/bezier-icons@0.47.0 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - ์ ๊ธฐ๋ฅ - ์๋ก์ด chat-edit ์์ด์ฝ ์ถ๊ฐ, ๊ธฐ์กด square ์์ด์ฝ ์ ๋ฐ์ดํธ - Figma ํ๋ฌ๊ทธ์ธ๊ณผ React ํจํค์ง์์ ์ต์ ์์ด์ฝ ์ ์ฉ - ์์ - bezier-icons 0.47.0, bezier-figma-plugin 0.7.5๋ก ๋ฒ์ ์ ๋ฐ์ดํธ ๋ฐ ์์กด์ฑ ์ ๋ฆฌ - ๋ถํ์ํ ๋ณ๊ฒฝ ์ธํธ ํ์ผ ์ ๋ฆฌ - ๊ณต๊ฐ API ๋ณํ ์์ - ๋ฌธ์ - ๊ฐ ํจํค์ง์ ๋ณ๊ฒฝ ๋ก๊ทธ ์ ๋ฐ์ดํธ (์ ๊ท ๋ฒ์ ๊ธฐ๋ก ์ถ๊ฐ) <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Icon update is ready to be merged! ๐
Summary by CodeRabbit