Allow extra whitespace in merge commands #108
Conversation
rlycx
left a comment
rlycx
left a comment
There was a problem hiding this comment.
Looks good! I left a small idea for improvement, but it's nothing critical so feel free to disregard it :)
src/Logic.hs
Outdated
| parseMergeCommand config message = | ||
| let | ||
| messageCaseFold = Text.toCaseFold $ Text.strip message | ||
| messageCaseFold = Text.toCaseFold $ Text.unwords $ filter (not . Text.null) $ Text.words message |
There was a problem hiding this comment.
Minor nitpick: it might be nice to make a normalize function to group these transformations in (and maybe rename messageCaseFold to messageNormalized since case folding is not the only operation applied to it anymore) but that comes down to stylistic preference.
|
@OpsBotPrime merge! |
|
Your merge request has been denied, because merging on Fridays is not recommended. To override this behaviour use the command |
|
@OpsBotPrime merge! |
|
Pull request approved for merge by @ReinierMaas, rebasing now. |
|
Rebased as 6f1b2a3, waiting for CI … |
Approved-by: ReinierMaas Auto-deploy: false
|
Abandoning this pull request because it was closed. |
|
@OpsBotPrime merge and for real this time. @ReinierMaas the CI was never started due to Semaphore issues, I'll retry this for you. |
|
Pull request approved for merge by @bertptrs, rebasing now. |
* Frees disk space on Semaphore * Error on `nix-build` failures
Approved-by: bertptrs Auto-deploy: false
|
Rebased as 8cc81f5, waiting for CI … |
OpsBotPrime
force-pushed
the
command-parser-allow-whitespace
branch
from
e3641a0 to
8cc81f5
Compare
4 participants
XRef: #102
Yes, that is definitely more user-friendly!
Allowing extra whitespace in the merge commands to overcome the (somewhat) common double whitespace.