Skip to content

Add draft mode support#258

Open
tom-sherman wants to merge 3 commits intochangesets:mainfrom
tom-sherman:add-draft-mode-support
Open

Add draft mode support#258
tom-sherman wants to merge 3 commits intochangesets:mainfrom
tom-sherman:add-draft-mode-support

Conversation

@tom-sherman
Copy link

Closes #257

@changeset-bot
Copy link

changeset-bot bot commented Jan 25, 2023

🦋 Changeset detected

Latest commit: 32d69a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@changesets/action Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tom-sherman
Copy link
Author

Docs incoming...

@tom-sherman tom-sherman marked this pull request as draft January 25, 2023 18:24
@tom-sherman tom-sherman marked this pull request as ready for review January 25, 2023 18:30
@cruzdanilo
Copy link

is there something blocking this pr?

@mmarekbb
Copy link

@Andarist cold this PR be merged? This is a functionality we'd like to use, too.

@svenvoskamp
Copy link

Any updates on this? Would like to use this functionality

@nickfujita
Copy link

nickfujita commented Jan 30, 2025

@Andarist
Ping from 2025. Any chance we can get this merged in? I think it would provide a nicer solution to the issue of the Version Packages pr not triggering pull_request than closing and re-opening the PR.
#187

@altano
Copy link

altano commented Mar 31, 2025

I know this probably isn't getting merged anytime soon, but I just wanted to mention that, taking a cue from https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#triggering-further-workflow-runs, we probably want the PR to always be set back to a draft when it's updated. So if the versions change it goes back to draft, and if the workflow has on: ready_for_review, it'll be retriggered everytime you the PR is updated and you set it back to ready for review.

Without this, the workflow will get triggered on the first draft -> publish, but not whenever the PR is updated by this action.

head: versionBranch,
title: finalPrTitle,
body: prBody,
draft: createPrAsDraft,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have the same validation when updating the PR in the block below.

Or create a new property for converting back to draft: updatePrConvertToDraft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow creating the PR in draft mode

8 participants