Action v1.5.2 closes existing version PR

[jacksonneal]

We've discovered what we believe is a bug in v1.5.2. We are using changesets with the following config:

      - id: changesets
        uses: changesets/action@v1.5.2
        with:
          publish: pnpm run publish
          setupGitUser: false
          commitMode: github-api
        env:
          GITHUB_TOKEN: ${{ steps.app-token.outputs.token }}

This works fine if there is no current "Version Packages" PR open as it will create one. But if I merge additional changefiles to main, the action will close the "Version Packages" PR and then correctly push the update version and changelog. The workaround is to manually reopen the PR or downgrade the action version. This is not an issue in v1.5.1.

Possibly related to this change: #473.

cc @jackheinemann

[s0]

Hmm this is interesting. With github-api, it always closes the PR (implicitly, as it needs to reset the branch before committing the new file changes over the API), but then it should re-open the PR afterwards.

Did you have exactly the same arguments with your usage of v1.5.1? I'll open up a repo to test with.

[s0]

Hmm looks to me like the same thing is happening with v1.5.1: s0/changests-action-tests#1

looks like in this case it closed opened a new PR instead of updating the existing one: s0/changests-action-tests#2

Still testing

[jacksonneal]

Yes, using the same args. Interesting to see that v1.5.1 fails, we tested a couple times and it seemed to work fine.

[s0]

Okay so few more experiments, these ones worked (correctly re-opened existing PR):

• v1.5.0
  • https://github.com/s0/changests-action-tests/actions/runs/14982772638
  • https://github.com/s0/changests-action-tests/actions/runs/14982784438
• v1.5.1
  • https://github.com/s0/changests-action-tests/actions/runs/14982822765/job/42090684987

These one's didn't work (didn't find existing PR, opened a new one):

• v1.5.1
  • https://github.com/s0/changests-action-tests/actions/runs/14982794915/job/42090593712
  • https://github.com/s0/changests-action-tests/actions/runs/14982851670
  • https://github.com/s0/changests-action-tests/actions/runs/14982873627

So it doesn't look like it's actually correlated with the version, and may be down to speed of the GitHub API (or something else outside of the context of the action).

From the output, you can see that it prints an empty array when it fails, which will be this line:

https://github.com/s0/changests-action-tests/actions/runs/14982873627

So it's (correctly) detecting a PR is not already open (as the changes pushed above are already being reflected in the GitHub REST API, and resetting the branch as part of pushing the new changes using ghcommit closed the PR).

(So FWIW, I think this has existed in all versions of v1.5.x, it's just we haven't had enough people run into this race-condition)

Seems like the fix will be as simple as making sure we get the list of existing PRs before we push any changes :)

[s0]

Okay this PR should fix things if my suspicion is correct: #488

@jacksonneal could you check a couple of things apply for you:

• in stdout, the action prints out []
• it will open a different new PR for the version update

[jacksonneal]

If you're asking when we were able to successfully run with v1.5.1

1. Yes, prints [] to stdout
2. Yes, I believe it closed and then opened and a new PR.

Or are you asking me to run with this branch version of the action?

[s0]

Or are you asking me to run with this branch version of the action?

Yeah I mean with v1.5.2

[jacksonneal]

Sorry if there's some confusion. v1.5.2 prints [] to stdout, closes the PR, but did not open any new PR. If it did open a new PR, I'd be ok with it.