Remove usage of `process.chdir()`

[s0]

See: #473 (comment)

As of #473, we now explicitly set the cwd argument for all subprocess calls. As such, it shouldn't be necessary to change the working directory of the current process.

We need to ensure that usage of commitChangesFromRepo (which makes a call to process.cwd()) also works correctly for our use-cases before we can remove this process call.

Namely, we need a way for running this action to work when:

• a repository is checked-out into a sub-directory.
• cwd is set to a subdirectory of that subdirectory

In particular, we should:

• Update commitChangesFromRepo so that repoDirectory can be used to recursively start a search for the root of a repository.
• Specify repoDirectory to be explicit cwd, as with addFromDirectory.

[ikovic]

Hi! I'm hoping this info could be useful input for further work on this - today we noticed that our CI has been broken since the 1.5.2 release.

This is our job definition:

      - name: Create and publish versions
        uses: changesets/action@v1
        with:
          cwd: web/sdk
          publish: yarn publish:ci
        env:  // omitted

The package we're managing using changesets is in web/sdk and since this release this action has been failing consistently with this message:

Run changesets/action@v1
  with:
    cwd: web/sdk
    publish: yarn publish:ci
    setupGitUser: true
    createGithubReleases: true
    commitMode: git-cli
  env:
    GITHUB_TOKEN: ***
    NODE_AUTH_TOKEN: ***
    NPM_TOKEN: ***
changing directory to the one given as the input
setting git user
/usr/bin/git config user.name "github-actions[bot]"
Error: Error: The cwd: web/sdk does not exist!
Error: The cwd: web/sdk does not exist!

I am not in a position to debug this but my assumption is that since we ran cwd once already we might already be in the specified dir when running git.setupUser so the second time the dir is not found.

Two questions come to mind:

• is there anything we could change in the config to circumvent this behaviour for now?
• is this a bug? Eg is our setup different from the baseline? The docs say to use the cwd option if the project is not located in the root

Thanks and please let me know if I can help.

[s0]

Ah okay i see what's causing this, @Andarist it's due to cwd being a relative path, so we can't actually set it for any of the exec calls, as it will try to set it from within the cwd. Removing process.chdir will fix this 😅

[s0]

We could also use path.resolve() before we use the arg value, but we may as well just remove the call like outlined above.

[Andarist]

is there anything we could change in the config to circumvent this behaviour for now?

You could set it to a non-relative path.

We could also use path.resolve() before we use the arg value, but we may as well just remove the call like outlined above.

I'd say we should do it regardless of the process.chdir() removal.