Catalogue: Fix voting in catalogue refs #2860 #7085
+258
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ack to props.course) for prevVote so changing a rating doesn't alter the vote count.
Member
|
There's a Vue issue in CatalogueCourseCard, where you define a constant allowSelfSignup on line 265 but it already is defined on line 456. This should have broken your "yarn dev" execution. Can you please review? When I remove the definition on line 456, the start are not marked anymore when I vote (if I reload the page, my votes appears, but not if I just click on the stars, even if nobody voted before and there's only one vote). |
ywarnier
requested changes
Nov 22, 2025
| { immediate: false }, | ||
| ) | ||
| const allowSelfSignup = computed(() => { |
Member
There was a problem hiding this comment.
This breaks "yarn dev" beause allowSelfSignup is already defined on line 456.
Actually, the one that breaks is the one on line 456, but I mean there's a duplicate definition of the same constant and that does not work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.