Skip to content

Plugin: BBB: Handle 413 gracefully and compact pre-upload UI - refs #3244 #6645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2025
Merged

Plugin: BBB: Handle 413 gracefully and compact pre-upload UI - refs #3244 #6645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions public/plugin/Bbb/lib/bbb.lib.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,18 +543,27 @@ public function createMeeting($params)
while ($status === false) {
$result = $this->api->createMeetingWithXmlResponseArray($bbbParams);

if (is_array($result) && (string) ($result['returncode'] ?? '') === 'SUCCESS') {
if ((string)($result['returncode'] ?? '') === 'SUCCESS') {
if ($this->plugin->get('allow_regenerate_recording') === 'true' && !empty($result['internalMeetingID'])) {
$meeting->setInternalMeetingId($result['internalMeetingID']);
$em->flush();
}

return $this->joinMeeting($meetingName, true);
}

// Break condition to avoid infinite loop if API keeps failing
if ((string)($result['returncode'] ?? '') === 'FAILED') {
if ((int)($result['httpCode'] ?? 0) === 413) {
if ($this->debug) {
error_log('BBB createMeeting failed (413): payload too large');
}
} else if ($this->debug) {
error_log('BBB createMeeting failed: '.json_encode($result));
}
break;
}

if ($this->debug) {
error_log('BBB createMeeting failed, response: '.print_r($result, true));
error_log('BBB createMeeting unexpected response: '.print_r($result, true));
}
break;
}
Expand Down
97 changes: 58 additions & 39 deletions public/plugin/Bbb/lib/bbb_api.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
*/

use BigBlueButton\BigBlueButton;
use BigBlueButton\Exceptions\BadResponseException;
use BigBlueButton\Parameters\Config\DocumentOptionsStore;
use BigBlueButton\Parameters\CreateMeetingParameters;
use BigBlueButton\Parameters\JoinMeetingParameters;
Expand Down Expand Up @@ -104,48 +105,66 @@ public function getCreateMeetingUrl(array $p): string
*/
public function createMeetingWithXmlResponseArray(array $p): array
{
$cp = new CreateMeetingParameters($p['meetingId'], $p['meetingName']);
$cp->setAttendeePassword($p['attendeePw']);
$cp->setModeratorPassword($p['moderatorPw']);
if (!empty($p['welcomeMsg'])) $cp->setWelcomeMessage($p['welcomeMsg']);
if (isset($p['dialNumber'])) $cp->setDialNumber($p['dialNumber']);
if (isset($p['voiceBridge'])) $cp->setVoiceBridge((int)$p['voiceBridge']);
if (isset($p['webVoice'])) $cp->setWebVoice($p['webVoice']);
if (isset($p['logoutUrl'])) $cp->setLogoutUrl($p['logoutUrl']);
if (isset($p['maxParticipants'])) $cp->setMaxParticipants((int)$p['maxParticipants']);
if (isset($p['record'])) $cp->setRecord((bool)$p['record']);
if (isset($p['duration'])) $cp->setDuration((int)$p['duration']);

if (!empty($p['documents']) && is_array($p['documents'])) {
foreach ($p['documents'] as $doc) {
$options = new DocumentOptionsStore();
$options->addAttribute('removable', (bool) $doc['removable']);
$cp->addPresentation(
$doc['filename'],
file_get_contents($doc['url']),
$doc['filename'],
$options
);
try {
$cp = new CreateMeetingParameters($p['meetingId'], $p['meetingName']);
$cp->setAttendeePassword($p['attendeePw']);
$cp->setModeratorPassword($p['moderatorPw']);
if (!empty($p['welcomeMsg'])) $cp->setWelcomeMessage($p['welcomeMsg']);
if (isset($p['dialNumber'])) $cp->setDialNumber($p['dialNumber']);
if (isset($p['voiceBridge'])) $cp->setVoiceBridge((int)$p['voiceBridge']);
if (isset($p['webVoice'])) $cp->setWebVoice($p['webVoice']);
if (isset($p['logoutUrl'])) $cp->setLogoutUrl($p['logoutUrl']);
if (isset($p['maxParticipants'])) $cp->setMaxParticipants((int)$p['maxParticipants']);
if (isset($p['record'])) $cp->setRecord((bool)$p['record']);
if (isset($p['duration'])) $cp->setDuration((int)$p['duration']);

if (!empty($p['documents']) && is_array($p['documents'])) {
foreach ($p['documents'] as $doc) {
$opts = new DocumentOptionsStore();
$opts->addAttribute('removable', (bool)($doc['removable'] ?? true));
$cp->addPresentation(
$doc['filename'] ?? basename(parse_url($doc['url'], PHP_URL_PATH) ?: 'document'),
file_get_contents($doc['url']),
$doc['filename'] ?? 'document',
$opts
);
}
}

$r = $this->client->createMeeting($cp);
$xml = $r->getRawXml();

return [
'returncode' => (string)$xml->returncode,
'message' => (string)$xml->message,
'messageKey' => (string)$xml->messageKey,
'meetingId' => (string)$xml->meetingID,
'attendeePw' => (string)$xml->attendeePW,
'moderatorPw' => (string)$xml->moderatorPW,
'hasBeenForciblyEnded' => (string)$xml->hasBeenForciblyEnded,
'createTime' => (string)$xml->createTime,
'internalMeetingID' => (string)$xml->internalMeetingID,
];
} catch (BadResponseException $e) {
$http = 0;
if (preg_match('/HTTP code:\s*(\d+)/i', $e->getMessage(), $m)) {
$http = (int)$m[1];
}
return [
'returncode' => 'FAILED',
'messageKey' => $http === 413 ? 'requestEntityTooLarge' : 'badResponse',
'message' => $http === 413
? 'One or more presentations exceed the upload limit on the video-conference server.'
: $e->getMessage(),
'httpCode' => $http,
];
} catch (\Throwable $e) {
return [
'returncode' => 'FAILED',
'messageKey' => 'unexpectedError',
'message' => $e->getMessage(),
];
}

/** @var CreateMeetingResponse $r */
$r = $this->client->createMeeting($cp);
$xml = $r->getRawXml();

// Map XML fields to array
return [
'returncode' => (string) $xml->returncode,
'message' => (string) $xml->message,
'messageKey' => (string) $xml->messageKey,
'meetingId' => (string) $xml->meetingID,
'attendeePw' => (string) $xml->attendeePW,
'moderatorPw' => (string) $xml->moderatorPW,
'hasBeenForciblyEnded' => (string) $xml->hasBeenForciblyEnded,
'createTime' => (string) $xml->createTime,
'internalMeetingID' => (string) $xml->internalMeetingID,
];
}

/**
Expand Down
157 changes: 118 additions & 39 deletions public/plugin/Bbb/listing.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

use Chamilo\CoreBundle\Entity\ConferenceActivity;
use Chamilo\CoreBundle\Entity\ConferenceMeeting;
use Chamilo\CoreBundle\Enums\ActionIcon;
use Chamilo\CourseBundle\Entity\CGroup;

$course_plugin = 'bbb'; // Needed to load plugin lang variables.
Expand Down Expand Up @@ -435,51 +436,129 @@
if ($conferenceManager && $allowToEdit) {
$form = new FormValidator('start_conference', 'post', $conferenceUrl);
$form->addElement('hidden', 'action', 'start');
$ajaxUrl = api_get_path(WEB_PATH).'main/inc/ajax/plugin.ajax.php?plugin=bbb&a=list_documents&'.api_get_cidreq();
$ajaxUrl = api_get_path(WEB_PATH).'main/inc/ajax/plugin.ajax.php?plugin=bbb&a=list_documents&'.api_get_cidreq();
$maxTotalMb = (int) api_get_course_plugin_setting('bbb', 'bbb_preupload_max_total_mb', $courseInfo);
if ($maxTotalMb <= 0) { $maxTotalMb = 20; }

$title = htmlspecialchars(get_lang('Pre-upload Documents'), ENT_QUOTES);
$help = htmlspecialchars(get_lang('Select the PDF or PPTX files you want to pre-load as slides for the conference.'), ENT_QUOTES);
$loadingTxt = htmlspecialchars(get_lang('Loading'), ENT_QUOTES);
$noDocsTxt = htmlspecialchars(get_lang('No documents found'), ENT_QUOTES);
$failTxt = htmlspecialchars(get_lang('Failed to load documents'), ENT_QUOTES);
$maxLabel = htmlspecialchars(sprintf(get_lang('Max total: %d MB'), $maxTotalMb), ENT_QUOTES);

$iconHtml = Display::getMdiIcon(
ActionIcon::UPLOAD,
'ch-tool-icon',
null,
ICON_SIZE_MEDIUM,
$title
);

// Pre-upload UI: fetch available course docs and render as checkboxes.
$preuploadHtml = '
<details id="preupload-documents" class="mt-4 border rounded p-3 bg-gray-100">
<summary class="font-semibold cursor-pointer">'.get_lang('Pre-upload Documents').'</summary>
<div class="mt-2 text-gray-700">
<p class="text-sm mb-2">'.get_lang('Select the PDF or PPTX files you want to pre-load as slides for the conference.').'</p>
<div id="preupload-list">'.get_lang('Loading').'…</div>
</div>
</details>
<script>
document.addEventListener("DOMContentLoaded", function() {
var det = document.getElementById("preupload-documents");
if (!det) return;
det.addEventListener("toggle", function once() {
if (!det.open) return;
det.removeEventListener("toggle", once);
fetch("'.$ajaxUrl.'", {credentials:"same-origin"})
<div class="bbb-preupload" style="position:relative;">
<button type="button" id="bbb-pre-btn"
class="btn btn--icon"
title="'.$title.'"
style="position:absolute; right:0; top:-8px;">
'.$iconHtml.'
</button>

<div id="bbb-pre-pop" class="hidden"
style="position:absolute; right:0; top:28px; z-index:50;
width:340px; background:#fff; border:1px solid #e5e7eb;
border-radius:8px; box-shadow:0 8px 24px rgba(0,0,0,.12);
padding:10px;">
<div class="text-sm" style="margin-bottom:6px; color:#475569;">'.$help.'</div>
<div id="preupload-list"
class="text-sm"
style="max-height:220px; overflow:auto; border:1px solid #eef2f7;
border-radius:6px; padding:8px; color:#0f172a;">
'.$loadingTxt.'…
</div>
<div class="text-xs" style="margin-top:6px; color:#64748b;">
'.$maxLabel.' — <span id="preupload-total">0</span> MB
</div>
</div>
</div>

<script>
(function(){
var btn = document.getElementById("bbb-pre-btn");
var pop = document.getElementById("bbb-pre-pop");
var list = document.getElementById("preupload-list");
var loaded = false;
var ajax = "'.$ajaxUrl.'";
var maxMb = '.$maxTotalMb.';

function esc(t){
return String(t).replace(/[&<>\"\\\']/g, function(s){
return {"&":"&amp;","<":"&lt;",">":"&gt;","\\"":"&quot;","\\\'":"&#39;"}[s];
});
}

function togglePop(){
if (pop.classList.contains("hidden")) {
pop.classList.remove("hidden");
if (!loaded) {
loaded = true;
fetch(ajax, {credentials:"same-origin"})
.then(function(r){ return r.json(); })
.then(function(docs){
var c = document.getElementById("preupload-list");
if (!Array.isArray(docs) || !docs.length) {
c.innerHTML = \'<p class="text-sm text-gray-500">'.addslashes(get_lang('No documents found.')).'</p>\';
return;
}
var filtered = docs.filter(function(doc){
return (doc.filename || "").match(/\\.(pdf|ppt|pptx|odp)$/i);
});
if (!filtered.length) {
c.innerHTML = \'<p class="text-sm text-gray-500">'.addslashes(get_lang('No documents found.')).'</p>\';
return;
}
c.innerHTML = filtered.map(function(doc){
var data = JSON.stringify({url:doc.url, filename:doc.filename}).replace(/"/g, "&quot;");
return \'<label class="block"><input type="checkbox" name="documents[]" value="\' + data + \'"> \' + (doc.filename || "") + \'</label>\';
}).join("");
})
.then(renderList)
.catch(function(){
document.getElementById("preupload-list").innerHTML =
\'<p class="text-sm text-red-500">'.addslashes(get_lang('Failed to load documents.')).'</p>\';
list.innerHTML = \'<p class="text-sm" style="color:#dc2626">'.$failTxt.'</p>\';
});
});
}
} else {
pop.classList.add("hidden");
}
}

function clickOutside(e){
if (!pop.contains(e.target) && !btn.contains(e.target)) {
pop.classList.add("hidden");
}
}

function renderList(docs){
var items = Array.isArray(docs) ? docs.filter(function(d){
return (d.filename||"").match(/\\.(pdf|ppt|pptx|odp)$/i);
}) : [];

if (!items.length) {
list.innerHTML = \'<p class="text-sm" style="color:#64748b">'.$noDocsTxt.'</p>\';
return;
}

list.innerHTML = items.map(function(doc){
var data = JSON.stringify({url:doc.url, filename:doc.filename, size:doc.size}).replace(/"/g,"&quot;");
return \'<label class="flex items-center gap-2" style="display:flex;align-items:center;gap:.5rem;margin:.25rem 0;">\'
+ \'<input type="checkbox" class="h-4 w-4" name="documents[]" value="\' + data + \'" />\'
+ \'<span class="truncate">\' + esc(doc.filename||"") + \'</span>\'
+ \'</label>\';
}).join("");

list.addEventListener("change", recalcTotal, true);
}

function recalcTotal(){
var boxes = list.querySelectorAll(\'input[type="checkbox"]:checked\');
var total = 0;
boxes.forEach(function(b){
try { var o = JSON.parse(b.value.replace(/&quot;/g, \'"\')); total += (o.size||0); } catch(e){}
});
</script>';
var mb = (total/1048576).toFixed(1);
var out = document.getElementById("preupload-total");
if (out) out.textContent = mb;

var submit = document.querySelector(\'form[name="start_conference"] [type="submit"]\');
if (submit) submit.disabled = (total > maxMb * 1048576);
}

if (btn) btn.addEventListener("click", togglePop);
document.addEventListener("click", clickOutside);
})();
</script>';

$form->addElement('html', $preuploadHtml);
$form->addElement(
Expand Down
41 changes: 41 additions & 0 deletions public/plugin/Bbb/start.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,48 @@
}
}

$maxTotalMb = (int) api_get_course_plugin_setting('bbb', 'bbb_preupload_max_total_mb', api_get_course_info());
if ($maxTotalMb <= 0) { $maxTotalMb = 20; }

$totalBytes = 0;
if (!empty($_POST['documents']) && is_array($_POST['documents'])) {
$docs = [];
foreach ($_POST['documents'] as $raw) {
$json = html_entity_decode($raw);
$doc = json_decode($json, true);
if (!is_array($doc) || empty($doc['url'])) { continue; }
$totalBytes += (int)($doc['size'] ?? 0);
$docs[] = [
'url' => $doc['url'],
'filename' => $doc['filename'] ?? basename(parse_url($doc['url'], PHP_URL_PATH)),
'downloadable'=> true,
'removable' => true,
];
}

if ($totalBytes > ($maxTotalMb * 1024 * 1024)) {
$message = Display::return_message(
sprintf(get_lang('The total size of selected documents exceeds %d MB.'), $maxTotalMb),
'error'
);
$tpl->assign('message', $message);
$tpl->assign('content', $message);
$tpl->display_one_col_template();
exit;
}

if (!empty($docs)) {
$meetingParams['documents'] = $docs;
}
}

$url = $bbb->createMeeting($meetingParams);
if (!$url) {
$message = Display::return_message(
get_lang('The selected documents exceed the upload limit of the video-conference server. Try fewer/smaller files or contact your administrator.'),
'error'
);
}
}
}

Expand Down
Loading