Course: Add support for resource sequencing in course and session views - refs rna-22586 #6330
Conversation
…ws - refs rna-22586
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
assets/vue/services/courseService.js
Outdated
| * @param {number=} sessionId - Optional session ID. | ||
| * @returns {Promise<{ available: boolean, nextCourse: object|null }>} | ||
| */ | ||
| getNextCourse: async (courseId, sessionId = 0) => { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| return $result; | ||
| } | ||
|
|
||
| private function checkRequirementsOrDependentsForUser( |
There was a problem hiding this comment.
Method checkRequirementsOrDependentsForUser has 63 lines of code (exceeds 25 allowed). Consider refactoring.
| ); | ||
| } | ||
|
|
||
| private function getRequirementsOrDependents(int $resourceId, int $resourceType, string $itemType): array |
There was a problem hiding this comment.
Method getRequirementsOrDependents has 36 lines of code (exceeds 25 allowed). Consider refactoring.
| return $result; | ||
| } | ||
|
|
||
| private function checkRequirementsOrDependentsForUser( |
There was a problem hiding this comment.
Function checkRequirementsOrDependentsForUser has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
| ); | ||
| } | ||
|
|
||
| private function getRequirementsOrDependents(int $resourceId, int $resourceType, string $itemType): array |
There was a problem hiding this comment.
Function getRequirementsOrDependents has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
| import { ref } from "vue" | ||
| import courseService from "../../services/courseService" | ||
|
|
||
| export function useCourseRequirementStatus(courseId, sessionId, onLockChange = null) { |
There was a problem hiding this comment.
Function useCourseRequirementStatus has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
| import { ref } from "vue" | ||
| import courseService from "../../services/courseService" | ||
|
|
||
| export function useCourseRequirementStatus(courseId, sessionId, onLockChange = null) { |
There was a problem hiding this comment.
Function useCourseRequirementStatus has 41 lines of code (exceeds 25 allowed). Consider refactoring.
| const graphImage = ref(null) | ||
| const loading = ref(true) | ||
|
|
||
| async function fetchStatus() { |
There was a problem hiding this comment.
Function fetchStatus has 26 lines of code (exceeds 25 allowed). Consider refactoring.
|
Code Climate has analyzed commit f9d8f5e and detected 5 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
No description provided.