Gradebook: Fix download all certificates - refs BT#19159 #3974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lint errors were found. A patch is also available. Please see the report: https://flintci.io/repositories/1013/analyses/64970 This comment was posted by FlintCI. It can be disabled in the repository settings. |
Member
|
Esta todo bien a nivel funcional, solo falta validacion del codigo para acceptar este PR. |
Member
|
Acepto este PR, pero me parece raro que se use la fecha UTC, a menos que haya sido un pedido del cliente. Usualmente la gente no es consciente de la otras zonas horarias que la suya, y en el caso de California, por ejemplo, podría muy bien terminar mostrando la fecha del día siguiente al en que se está generando el exporte... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.