Plugin: BuyCourses: Prevented design breakage for cards #3683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Into https://campus.chamilo.org/plugin/buycourses/src/session_catalog.php?&page=5
It can be seen that, despite being 6 cards, the design is broken, this is because in one of the cards, the image does not respect the aspect by 1 px.
The height property differs from the other images
This pixel causes the images to not be ordered well.
A change is proposed for max-height. The image is encapsulated in a figure so that the image maintains its shape, however the figure is the one who will be the appropriate responsive container so that it does not break the design.
This way, even with resolutions of 3600 px wide, the original design will not be broken.
BT#17957