Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for full width characters #9

Merged
merged 2 commits into from
Jul 1, 2017
Merged

Add support for full width characters #9

merged 2 commits into from
Jul 1, 2017

Conversation

kevva
Copy link
Contributor

@kevva kevva commented Jul 1, 2017

Fixes #4.

@Qix- Qix- requested a review from sindresorhus July 1, 2017 07:26
@Qix-
Copy link
Member

Qix- commented Jul 1, 2017

LGTM. Wish it didn't require another dependency but that's more Node's/javascript's fault.

@sindresorhus sindresorhus merged commit 0554671 into chalk:master Jul 1, 2017
@sindresorhus
Copy link
Member

Hmm, this is failing when merged into master: https://travis-ci.org/chalk/slice-ansi/builds/249111405?utm_source=github_status&utm_medium=notification

@kevva
Copy link
Contributor Author

kevva commented Jul 1, 2017

Yeah, I made a comment about it here 0554671#commitcomment-22868677.

@TiagoDanin TiagoDanin mentioned this pull request Sep 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus Awaiting requested review from sindresorhus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevva @Qix- @sindresorhus