Skip to content
This repository was archived by the owner on Oct 23, 2023. It is now read-only.

feat: add ref typings for react, preact and solid #327

Merged
merged 10 commits into from
Apr 1, 2023

Conversation

TimKolberger
Copy link
Collaborator

@TimKolberger TimKolberger commented Apr 1, 2023

react, preact and solid

When using the as prop, the ref will now be typed accordingly.

react

Removed the member defaultProps from the type ComponentWithAs to support React 18.3.0.

@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Merging #327 (00a549d) into main (dd062b4) will decrease coverage by 0.31%.
The diff coverage is 99.64%.

❗ Current head 00a549d differs from pull request most recent head 6c43fe4. Consider uploading reports for the commit 6c43fe4 to get more accurate results

@@             Coverage Diff             @@
##              main     #327      +/-   ##
===========================================
- Coverage   100.00%   99.69%   -0.31%     
===========================================
  Files            3       11       +8     
  Lines          145      660     +515     
  Branches        10       58      +48     
===========================================
+ Hits           145      658     +513     
- Misses           0        2       +2     
Flag Coverage Δ
preact 100.00% <100.00%> (?)
react 100.00% <100.00%> (?)
solid 100.00% <100.00%> (?)
vue 98.83% <98.83%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/vue/src/use-v-model.ts 96.61% <96.61%> (ø)
packages/preact/src/forwardRef.tsx 100.00% <100.00%> (ø)
packages/preact/src/index.ts 100.00% <100.00%> (ø)
packages/preact/src/polymorphic-factory.tsx 100.00% <100.00%> (ø)
packages/react/src/forwardRef.tsx 100.00% <100.00%> (ø)
packages/react/src/index.ts 100.00% <100.00%> (ø)
packages/react/src/polymorphic-factory.tsx 100.00% <100.00%> (ø)
packages/solid/src/index.ts 100.00% <100.00%> (ø)
packages/solid/src/polymorphic-factory.tsx 100.00% <100.00%> (ø)
packages/vue/src/index.ts 100.00% <100.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@TimKolberger TimKolberger merged commit b572666 into main Apr 1, 2023
@TimKolberger TimKolberger deleted the feat/ref-typings branch April 1, 2023 13:41
@github-actions github-actions bot mentioned this pull request Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant