This repository was archived by the owner on Oct 23, 2023. It is now read-only.
feat: add polymorphic factory for solid #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimKolberger
changed the base branch from
main
to
feat/explicit-types-and-exports
Codecov Report
@@ Coverage Diff @@
## main #27 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 3 5 +2
Lines 145 269 +124
Branches 10 18 +8
==========================================
+ Hits 145 269 +124
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
TimKolberger
force-pushed
the
feat/solid
branch
from
b9c2165 to
2834a70
Compare
TimKolberger
force-pushed
the
feat/solid
branch
from
2834a70 to
31107f7
Compare
TimKolberger
force-pushed
the
feat/solid
branch
from
31107f7 to
ddc01ca
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ported the polymorphic factory to solid and used the built in
Dynamiccomponent.Seems to work as good as with React 🎉