This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Bugfix/story issues #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebender828
suggested changes
Mar 16, 2020
There was a problem hiding this comment.
Great work with this, @koca .
On the Radio component, we need to remove the defaultIsChecked key from the attrs since we've now moved it to domProps.
koca
commented
Mar 16, 2020
|
Great work. |
codebender828
approved these changes
Mar 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #49 storybook issues
also added tests for:
and slider component works on my machine so we should try to reproduce the issue on linux i guess