fix(select): prevent duplicated ID on wrapper + input #490
Conversation
by filtering the attributes passed to the wrapper component and thus passing the ID only to the select itself. Also adds very basic tests for CSelect and a story for the disabled select field. fixes chakra-ui#484
🦋 Changeset detectedLatest commit: c5fe636 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). chakra-ui-vue – ./🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-vue/Gpqg5F8pKmCcEjFbu3Jm596B4iD2 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c5fe636:
|
|
What needs to happen here to get this merged, @peoray? |
|
@HerrBertling haven't had the time to take a look. I'll see to that this weekend, hopefully, we have a new release next week. Stay tuned :) |
Description
This prevents a duplicated
idon wrapper + input by filtering the attributes passed to the wrapper componentand thus passing the
idonly to the select itself.Also adds very basic tests for
CSelectand a story for the disabled select field.Motivation and Context
fixes #484
How Has This Been Tested?
I've added a test to check for the correctly passed
idonto theselectand not the wrapper :)Types of changes
Checklist: