Skip to content

FreeLoopBodyJobs race condition. #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2016
Merged

FreeLoopBodyJobs race condition. #979

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/Backend/NativeCodeGenerator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@ void SetProfileMode(BOOL fSet);
: JsUtil::WaitableJobManager(processor)
, autoClose(true)
, isClosed(false)
, processed(false)
{
Processor()->AddManager(this);
}
Expand Down Expand Up @@ -238,7 +239,7 @@ void SetProfileMode(BOOL fSet);

FreeLoopBodyJob* GetJob(FreeLoopBodyJob* job)
{
return job;
return this->processed ? nullptr : job;
}

bool WasAddedToJobProcessor(JsUtil::Job *const job) const
Expand Down Expand Up @@ -268,6 +269,8 @@ void SetProfileMode(BOOL fSet);
{
FreeLoopBodyJob* freeLoopBodyJob = static_cast<FreeLoopBodyJob*>(job);

this->processed = true;

if (freeLoopBodyJob->heapAllocated)
{
HeapDelete(freeLoopBodyJob);
Expand All @@ -280,6 +283,7 @@ void SetProfileMode(BOOL fSet);
NativeCodeGenerator* nativeCodeGen;
bool autoClose;
bool isClosed;
bool processed;
};

FreeLoopBodyJobManager freeLoopBodyManager;
Expand Down